Repository navigation
Extract the bind confirmation prompt into confirmBindPlan - #7058
Closed
shreyas-goenka wants to merge 1 commit into
Closed
shreyas-goenka wants to merge 1 commit into
shreyas-goenka wants to merge 1 commit into
Conversation
The plan preview and approval prompt move out of phases.Bind into a helper that reads the action from the plan, so BindResult no longer carries HasChanges and Action. No behavior change; a later change reuses the prompt for DMS bind. Co-authored-by: Isaac <no-reply@databricks.com>
shreyas-goenka
added this pull request to stack #7062
October 14, 2026 15:03
Collaborator
Integration test reportCommit: dd25cca
Top 11 slowest tests (at least 2 minutes):
|
shreyas-goenka
commented
Oct 19, 2026
| } | ||
|
|
||
| // Check if the bound resource has changes | ||
| result := &BindResult{ |
Contributor
Author
There was a problem hiding this comment.
Are these used anywhere? Lets remove?
shreyas-goenka
removed this pull request from stack #7062
October 19, 2026 15:52
Contributor
Author
|
Superseded by stack #7114 (bind as a single planned action, one shared flow). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the bind plan preview and approval prompt into a
confirmBindPlanhelper and drops the now-unusedBindResult.HasChanges/Actionfields.This refactor is done so that DMS support for bind can later use the same prompt function.